Revamp S3 range validation with detailed message #437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp S3 range validation with detailed message and allow 0 as the range start value.
For S3 Backfills -
The range isn’t actually defaulting to 0 — what’s happening is that it’s cloning the values from the previous run. For example, this run has a range of 0 to null. So when cloned, the start value of 0 gets copied over. On the other hand, this run has both start and end as null, so those values are cloned instead.
This means that if a previous run had a start value of 0, and the user selects RESTART, that 0 will be reused — which can will cause errors for S3 since valid range should not be there. To avoid this, We want to support a start value of 0 for S3 backfills.