Skip to content

Enable ETA on the new UI #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Enable ETA on the new UI #440

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c64ed2
enable eta
jeffhwang-sq Apr 22, 2025
3487c72
computing size to computing
jeffhwang-sq Apr 22, 2025
4e8e378
Merge branch 'master' into jeffhwang-enable-eta-on-revamped-ui
jeffhwang-sq Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 49 additions & 2 deletions service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,18 @@ class BackfillShowAction @Inject constructor(
)
}
td("hidden py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700 sm:table-cell") { +"""${partition.matching_records_per_minute} #/m""" }
// TODO properly calculate the ETA until finished
td("py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700") { +"""ETA TODO""" }
td("py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700") {
when {
partition.state != BackfillState.RUNNING -> +"-"
!partition.precomputing_done -> +"Computing size..."
partition.matching_records_per_minute == null || partition.matching_records_per_minute <= 0 ||
partition.computed_matching_record_count <= 0 -> +"Calculating..."
else -> {
val etaSeconds = (partition.computed_matching_record_count - partition.backfilled_matching_record_count).toDouble() / (partition.matching_records_per_minute / 60.0)
+formatEta(etaSeconds * 1000)
}
}
}
}
}
}
Expand Down Expand Up @@ -476,6 +486,43 @@ class BackfillShowAction @Inject constructor(
}
}

private fun formatEta(etaMillis: Double): String {
val durationSeconds = etaMillis / 1000
var temp = durationSeconds.toLong()
val sb = StringBuilder()

val years = temp / 31536000
if (years > 0) {
sb.append("${years}y")
temp %= 31536000
}

val days = temp / 86400
if (days > 0) {
sb.append("${days}d")
temp %= 86400
}

val hours = temp / 3600
if (hours > 0) {
sb.append("${hours}h")
temp %= 3600
}

val minutes = temp / 60
if (minutes > 0) {
sb.append("${minutes}m")
temp %= 60
}

val seconds = temp
if (seconds > 0) {
sb.append("${seconds}s")
}

return if (sb.isEmpty()) "< 1s" else sb.toString()
}

companion object {
private const val PATH = "/backfills/{id}"
fun path(id: String) = PATH.replace("{id}", id)
Expand Down