Add proper state handling for rate display on the new UI #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
approved these changes
Apr 22, 2025
service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
Outdated
Show resolved
Hide resolved
mpawliszyn
reviewed
Apr 22, 2025
| td("hidden py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700 sm:table-cell") { | ||
| when { | ||
| partition.state != BackfillState.RUNNING -> +"-" | ||
| !partition.precomputing_done -> +"Computing..." |
There was a problem hiding this comment.
Records per minute shouldn't depend on the precomputing step. That is literally the rate of runBatch only and those should start right away.
There was a problem hiding this comment.
when I tested this out, the values were always 0 when precomputing was set to False, then when its set to True, the value gets filled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When precomputing
When precomputing is done, but no rate to provide
When in running state
When complete
Empty State Messages: