Skip to content

Add proper state handling for rate display on the new UI #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Add proper state handling for rate display on the new UI #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd6cc3
revamp rate on new ui
jeffhwang-sq Apr 22, 2025
0f38da0
shorten the computing size to computing
jeffhwang-sq Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,15 @@ class BackfillShowAction @Inject constructor(
partition.computed_matching_record_count,
)
}
td("hidden py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700 sm:table-cell") { +"""${partition.matching_records_per_minute} #/m""" }
td("hidden py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700 sm:table-cell") {
when {
partition.state != BackfillState.RUNNING -> +"-"
!partition.precomputing_done -> +"Computing..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Records per minute shouldn't depend on the precomputing step. That is literally the rate of runBatch only and those should start right away.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I tested this out, the values were always 0 when precomputing was set to False, then when its set to True, the value gets filled.
Screenshot 2025-04-22 at 10 57 19 AM
Screenshot 2025-04-22 at 10 56 38 AM

partition.matching_records_per_minute == null ||
partition.matching_records_per_minute <= 0 -> +"Calculating..."
else -> +"""${partition.matching_records_per_minute} #/m"""
}
}
// TODO properly calculate the ETA until finished
td("py-5 pl-8 pr-0 text-right align-top tabular-nums text-gray-700") { +"""ETA TODO""" }
}
Expand Down