Add "Cancelled" Button for Paused Backfills #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhwang-sq
force-pushed
the
jhwang/enable-cancellation-backfills
branch
from
2e8032b to
45c4c0b
Compare
jeffhwang-sq
changed the title
jeffhwang-sq
changed the title
adrw
reviewed
Apr 28, 2025
service/src/main/kotlin/app/cash/backfila/dashboard/CancelBackfillAction.kt
Outdated
Show resolved
Hide resolved
mpawliszyn
approved these changes
Apr 30, 2025
service/src/main/kotlin/app/cash/backfila/dashboard/CancelBackfillAction.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
Show resolved
Hide resolved
jeffhwang-sq
added a commit
that referenced
this pull request
May 7, 2025
This change introduces a Cancel button to the UI for backfills that are currently paused. Users can now manually transition a paused backfill to a CANCELLED state, providing better control over workflows that are no longer needed. Changes Include: - Added a cancel button in the backfill details view (only shown for paused backfills). - Updated run partition table state column and backfillruns table state column, handling to correctly mark backfills as CANCELLED when triggered. Next Pr will create a new deleted column to support hiding the backfill that are soft deleted. https://github.com/user-attachments/assets/b0072300-d0ef-47cb-946e-b52f97e97073 
jeffhwang-sq
added a commit
that referenced
this pull request
May 8, 2025
This pr fixes the merge issue for soft deletion feature. I am not sure what happened as I merged the three prs all together. There were lot of missing changes from the pr 444. #442 #443 #444 Retested after the recent code changes. Also verified event pagination, which was included in the last merge. https://github.com/user-attachments/assets/300f98b2-b28a-4d6a-b2f8-4ed985c980e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a Cancel button to the UI for backfills that are currently paused. Users can now manually transition a paused backfill to a CANCELLED state, providing better control over workflows that are no longer needed.
Changes Include:
Next Pr will create a new deleted column to support hiding the backfill that are soft deleted.
Screen.Recording.2025-04-28.at.2.47.50.PM.mov