Enable Soft Deletion Backfills #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhwang-sq
requested review from
adrw and
mpawliszyn
and removed request for
adrw
jeffhwang-sq
changed the base branch from
master
to
jhwang/enable-cancellation-backfills
adrw
approved these changes
Apr 28, 2025
service/src/main/resources/migrations/v020__add_soft_delete.sql
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/app/cash/backfila/service/persistence/DbBackfillRun.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/app/cash/backfila/service/persistence/BackfillSoftDelete.kt
Outdated
Show resolved
Hide resolved
adrw
reviewed
Apr 28, 2025
service/src/main/kotlin/app/cash/backfila/dashboard/SoftDeleteBackfillAction.kt
Outdated
Show resolved
Hide resolved
…e-soft-deletion-backfills * jhwang/enable-cancellation-backfills: add users to authenticattion
mpawliszyn
approved these changes
Apr 30, 2025
service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
Outdated
Show resolved
Hide resolved
service/src/main/resources/migrations/v020__add_soft_delete.sql
Outdated
Show resolved
Hide resolved
|
Make sure to follow up with updating the backfill page with the deleted at so there is some feedback when hitting delete. Maybe a banner at the top indicating that it is deleted? |
…e-soft-deletion-backfills * jhwang/enable-cancellation-backfills: address comments
jeffhwang-sq
merged commit 5233573
into
jhwang/enable-cancellation-backfills
5 checks passed
jeffhwang-sq
added a commit
that referenced
this pull request
May 8, 2025
This pr fixes the merge issue for soft deletion feature. I am not sure what happened as I merged the three prs all together. There were lot of missing changes from the pr 444. #442 #443 #444 Retested after the recent code changes. Also verified event pagination, which was included in the last merge. https://github.com/user-attachments/assets/300f98b2-b28a-4d6a-b2f8-4ed985c980e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow soft-delete backfills for cancelled and completed backfills.
Soft Deletion Handling: Backfila is updated to recognize and process records flagged as soft-deleted, ensuring they are included or excluded from backfills based on configuration.
A 'Delete' button has been added to cancelled or completed backfills in the UI, providing users with the ability to soft delete backfills.
We filter the deleted backfills from the UI.
Screen.Recording.2025-04-28.at.4.12.35.PM.mov
Modified to nullable timestamp
