Jhwang/add ability to modify partition #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On success, it should redirect back to the Backfill Show page. Alternatively it'd be nice to have the change form inline like the other config change buttons which turn into input boxes. |
Changes are done but let me see if I can add some tests. |
This change introduces a Cancel button to the UI for backfills that are currently paused. Users can now manually transition a paused backfill to a CANCELLED state, providing better control over workflows that are no longer needed. Changes Include: - Added a cancel button in the backfill details view (only shown for paused backfills). - Updated run partition table state column and backfillruns table state column, handling to correctly mark backfills as CANCELLED when triggered. Next Pr will create a new deleted column to support hiding the backfill that are soft deleted. https://github.com/user-attachments/assets/b0072300-d0ef-47cb-946e-b52f97e97073 
## Problem The DynamoDB BatchWriteItem API often has transient failures with unprocessed items that cause entire Backfila batches to fail. These could be more granularly retried within a run to avoid Backfila getting stuck on a batch. ## Solution Improve the retry mechanism to better align with [AWS BatchWriteItem best practices](https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_BatchWriteItem.html): - Collect unprocessed items across all batches and retry them together - Use exponential backoff with jitter to handle throttling - Only count towards retry limit when no progress is made - Provide more detailed error reporting
…#452) ## Problem The DynamoDB BatchWriteItem implementation in UpdateInPlaceDynamoDbBackfill currently lacks handling for ApiCallTimeoutException. When these timeouts occur, the entire batch fails without any retry attempts, causing backfills to fail unnecessarily. ## Solution Add comprehensive timeout handling with these features: - Track and retry chunks that experience API timeouts - Use exponential backoff with jitter for retries - Only increment the timeout counter when all chunks in an iteration timeout - Reset the timeout counter if any chunk succeeds - Maintain separate counters for timeouts vs unprocessed items - Provide detailed error context through suppressed exceptions The implementation is designed to be resilient to transient timeouts while still protecting against systemic failures. It coordinates the backoff strategy between timeout retries and unprocessed item retries.
adrw
approved these changes
May 8, 2025
service/src/main/kotlin/app/cash/backfila/dashboard/EditPartitionCursorHandlerAction.kt
Outdated
Show resolved
Hide resolved
service/src/test/kotlin/app/cash/backfila/actions/EditPartitionEndPointTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabe dynamic partition adjustments for paused backfills
Screen.Recording.2025-05-07.at.12.16.07.PM.mov