enable non numerical values for range #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhwang-sq
force-pushed
the
jhwang/enable-non-number-for-range
branch
from
da83002 to
d0a547a
Compare
mpawliszyn
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes involve modifications to the range-handling logic, allowing Backfila to process start and end range to be non-numeric values.
This change addresses a discussion raised in Slack. The backfill at Backfila #17385 uses Jooq backfills. Depending on the specific type of backfill, we want to support non-numerical range values and delegate range validation to the corresponding backfill operator. For instance, the StaticDatasourceBackfillOperator will enforce that ranges are numerical.
Will save this for Mike to review