From 6b596a193c77e4f237f2efd219fce72bd2ea6e14 Mon Sep 17 00:00:00 2001 From: Jeff Hwang Date: Wed, 14 May 2025 14:29:51 -0400 Subject: [PATCH 1/2] add last registered at --- .../kotlin/app/cash/backfila/api/ConfigureServiceAction.kt | 2 ++ .../app/cash/backfila/service/persistence/DbService.kt | 5 +++++ service/src/main/resources/migrations/v020__backfila.sql | 2 ++ 3 files changed, 9 insertions(+) create mode 100644 service/src/main/resources/migrations/v020__backfila.sql diff --git a/service/src/main/kotlin/app/cash/backfila/api/ConfigureServiceAction.kt b/service/src/main/kotlin/app/cash/backfila/api/ConfigureServiceAction.kt index fe835bc3b..09ab8ae8b 100644 --- a/service/src/main/kotlin/app/cash/backfila/api/ConfigureServiceAction.kt +++ b/service/src/main/kotlin/app/cash/backfila/api/ConfigureServiceAction.kt @@ -68,6 +68,7 @@ class ConfigureServiceAction @Inject constructor( request.connector_extra_data, request.slack_channel, variant, + clock.instant(), ) session.save(dbService) } else { @@ -75,6 +76,7 @@ class ConfigureServiceAction @Inject constructor( dbService.connector_extra_data = request.connector_extra_data dbService.slack_channel = request.slack_channel dbService.variant = variant + dbService.last_registered_at = clock.instant() } // Add any missing backfills, update modified ones, and mark missing ones as deleted. diff --git a/service/src/main/kotlin/app/cash/backfila/service/persistence/DbService.kt b/service/src/main/kotlin/app/cash/backfila/service/persistence/DbService.kt index de2efbe69..13e50e61c 100644 --- a/service/src/main/kotlin/app/cash/backfila/service/persistence/DbService.kt +++ b/service/src/main/kotlin/app/cash/backfila/service/persistence/DbService.kt @@ -37,17 +37,22 @@ class DbService() : DbUnsharded, DbTimestampedEntity { @Column override lateinit var updated_at: Instant + @Column(nullable = true) + var last_registered_at: Instant? = null + constructor( registry_name: String, connector: String, connector_extra_data: String?, slack_channel: String?, variant: String, + last_registered_at: Instant?, ) : this() { this.registry_name = registry_name this.connector = connector this.connector_extra_data = connector_extra_data this.slack_channel = slack_channel this.variant = variant + this.last_registered_at = last_registered_at } } diff --git a/service/src/main/resources/migrations/v020__backfila.sql b/service/src/main/resources/migrations/v020__backfila.sql new file mode 100644 index 000000000..a1938d317 --- /dev/null +++ b/service/src/main/resources/migrations/v020__backfila.sql @@ -0,0 +1,2 @@ +ALTER TABLE services +ADD COLUMN last_registered_at timestamp NULL; \ No newline at end of file From eb4c75f00e0a81ad937008301ec8e50407e30f40 Mon Sep 17 00:00:00 2001 From: Jeff Hwang Date: Fri, 16 May 2025 09:06:39 -0400 Subject: [PATCH 2/2] update the default timestamp --- service/src/main/resources/migrations/v020__backfila.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/src/main/resources/migrations/v020__backfila.sql b/service/src/main/resources/migrations/v020__backfila.sql index a1938d317..b1741ae10 100644 --- a/service/src/main/resources/migrations/v020__backfila.sql +++ b/service/src/main/resources/migrations/v020__backfila.sql @@ -1,2 +1,2 @@ ALTER TABLE services -ADD COLUMN last_registered_at timestamp NULL; \ No newline at end of file +ADD COLUMN last_registered_at TIMESTAMP(3) DEFAULT CURRENT_TIMESTAMP(3); \ No newline at end of file