Skip to content

Add last registered at column to Services #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

Add last registered at column to Services #458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b596a1
add last registered at
jeffhwang-sq May 14, 2025
eb4c75f
update the default timestamp
jeffhwang-sq May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions service/src/main/kotlin/app/cash/backfila/api/ConfigureServiceAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,15 @@ class ConfigureServiceAction @Inject constructor(
request.connector_extra_data,
request.slack_channel,
variant,
clock.instant(),
)
session.save(dbService)
} else {
dbService.connector = request.connector_type
dbService.connector_extra_data = request.connector_extra_data
dbService.slack_channel = request.slack_channel
dbService.variant = variant
dbService.last_registered_at = clock.instant()
}

// Add any missing backfills, update modified ones, and mark missing ones as deleted.
Expand Down
5 changes: 5 additions & 0 deletions service/src/main/kotlin/app/cash/backfila/service/persistence/DbService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,22 @@ class DbService() : DbUnsharded<DbService>, DbTimestampedEntity {
@Column
override lateinit var updated_at: Instant

@Column(nullable = true)
var last_registered_at: Instant? = null

constructor(
registry_name: String,
connector: String,
connector_extra_data: String?,
slack_channel: String?,
variant: String,
last_registered_at: Instant?,
) : this() {
this.registry_name = registry_name
this.connector = connector
this.connector_extra_data = connector_extra_data
this.slack_channel = slack_channel
this.variant = variant
this.last_registered_at = last_registered_at
}
}
2 changes: 2 additions & 0 deletions service/src/main/resources/migrations/v020__backfila.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ALTER TABLE services
ADD COLUMN last_registered_at timestamp NULL;