Reset consecutive failure count on range success #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the count of consecutive failures is only reset when a batch is fully completed. This can be problematic if the sizes of batches are imbalances and some batches are very large, where a single batch can contain many ranges that need to be processed. Normally when batches encounter transient failures, the count is reset when the batch is eventually processed and the backfill moves on - if, however, for a large enough batch, enough transient failures are encountered for ranges within that batch, the entire backfill will fail. This change resets the count of consecutive failures when a range within a batch is processed so backfills do not get stuck when this occurs.
mpawliszyn
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the count of consecutive failures is only reset when a batch is fully completed. This can be problematic if the sizes of batches are imbalanced and some batches are very large, where a single batch can contain many ranges that need to be processed. Normally when batches encounter transient failures, the count is reset when the batch is eventually processed and the backfill moves on - if, however, for a large enough batch, enough transient failures are encountered for ranges within that batch, the entire backfill will fail. This change resets the count of consecutive failures when a range within a batch is processed so backfills do not get stuck when this occurs.