Skip to content

Adjust rate logic to render even in precomputing stage #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Adjust rate logic to render even in precomputing stage #463

merged 3 commits into from
May 22, 2025

Conversation

jeffhwang-sq
Copy link
Collaborator

@jeffhwang-sq jeffhwang-sq commented May 21, 2025 •
edited
Loading

Fix a discrepancy in how backfill rates are displayed between the old and new UI implementations.

Issue

The new UI was incorrectly hiding valid rate information during precomputing phase. For example:

  • Old UI: Shows "300 #/m" (correct)
  • New UI: Shows "Computing..." (incorrect when we have a valid rate)
  • When the pre-computation is done, the rate matches with the old UI

Changes

Modified the rate display logic in BackfillShowAction.kt to:

  1. Show actual rates when available, even during precomputing
  2. Only show "Computing..." when there's no rate during precomputing
  3. Show "Calculating..." when there's no rate after precomputing is done

https://backfila.sqprod.co/backfills/29757
Old UI renders rate
Screenshot 2025-05-21 at 1 22 02 PM

New UI Does not
Screenshot 2025-05-21 at 1 21 58 PM

@jeffhwang-sq jeffhwang-sq requested review from mpawliszyn and adrw and removed request for mpawliszyn May 21, 2025 17:25
@jeffhwang-sq jeffhwang-sq marked this pull request as ready for review May 21, 2025 17:25
adrw
adrw approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@adrw adrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Braces for multi-line if statements pls

@jeffhwang-sq jeffhwang-sq enabled auto-merge (squash) May 22, 2025 22:10
@jeffhwang-sq jeffhwang-sq merged commit 669a833 into master May 22, 2025
5 checks passed
jeffhwang-sq added a commit that referenced this pull request May 28, 2025
@jeffhwang-sq
Merge branch 'master' into jhwang/add-units
bb75fca 
# By jeffhwang-sq
# Via GitHub
* master:
  Adjust rate logic to render even in precomputing stage (#463)
  Fix progress bar to match the old ui (#464)

# Conflicts:
#	client-dynamodb-v2/src/main/kotlin/app/cash/backfila/client/dynamodbv2/UpdateInPlaceDynamoDbBackfill.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrw adrw adrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffhwang-sq @adrw