Fix progress bar to match the old ui #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhwang-sq
force-pushed
the
jhwang/fix-progress-bar-new-ui
branch
from
0ca80fa to
570ff49
Compare
adrw
approved these changes
May 22, 2025
service/src/main/kotlin/app/cash/backfila/ui/components/ProgressBar.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/app/cash/backfila/ui/components/ProgressBarReloader.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix misleading progress bar behavior in new UI
Issue
The new UI's progress bar implementation has a bug where it shows misleading progress during precomputing:
Changes
Updated ProgressBar component to match old UI's behavior:
446211206-34dd7a28-bd6a-4f18-afe3-9ba0bf64208d.mov