Skip to content

Conversation

jeffhwang-sq
Copy link
Collaborator

Move state section to its own Turbo Frame

Changes

  • Moved state section to its own Turbo Frame with dedicated auto-reload
  • Extracted button rendering logic into reusable functions in BackfillShowButtonHandlerAction
  • Removed duplicate button helper functions from BackfillShowAction
  • Added proper frame response handling for state updates
Screen.Recording.2025-06-10.at.1.03.52.AM.mov

@jeffhwang-sq jeffhwang-sq marked this pull request as ready for review June 10, 2025 05:06
@jeffhwang-sq jeffhwang-sq requested review from adrw and mpawliszyn June 10, 2025 14:39
@jeffhwang-sq jeffhwang-sq changed the base branch from jhwang/enable-turbo-frame to master June 10, 2025 17:02
# By jeffhwang-sq
# Via GitHub
* master:
  Add turbo frame to events and partition (#469)

# Conflicts:
#	service/src/main/kotlin/app/cash/backfila/ui/pages/BackfillShowAction.kt
#	service/src/main/resources/web/static/js/auto_reload_controller.js
Copy link
Collaborator

@keeferrourke keeferrourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I think there's an issue with including a turbo_frame inside the body of an AutoReload component.

@jeffhwang-sq jeffhwang-sq merged commit 8b45a5a into master Jun 11, 2025
5 checks passed
jeffhwang-sq added a commit that referenced this pull request Jun 11, 2025
* master:
  Move state section to its own Turbo Frame (#470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants