Merge Move timezone formatting to server side to master
#504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add misk-grpc-reflect to libs.versions.toml - Include misk-grpc-reflect in service dependencies - Fixes NoClassDefFoundError: misk/grpc/reflect/GrpcReflectModule
There is flickering issue coming from client side timezone formatting. All timestamps are now formatted server side using the user's detected timezone as well as simplifying the javascript. Before: Flickering issue as the timezone gets rerendered https://github.com/user-attachments/assets/fe25a441-b718-4306-bf46-327b6ba8fb67 After: No flickering issue <img width="978" height="508" alt="Screenshot 2025-07-29 at 2 37 07 AM" src="https://github.com/user-attachments/assets/6b137133-8152-45a5-9a66-263cad17ccac" />
jeffhwang-sq
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#502