Skip to content

Fix EnvoyClientEndpointProvider Initialization #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025
Merged

Fix EnvoyClientEndpointProvider Initialization #507

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86bd373
add fix to envoy connector
jeffhwang-sq Aug 4, 2025
9ae4de6
modify comment
jeffhwang-sq Aug 4, 2025
9bfaba7
update client to misk
jeffhwang-sq Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions service/src/main/kotlin/app/cash/backfila/client/EnvoyCallbackConnectorProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class EnvoyCallbackConnectorProvider @Inject constructor(
private val moshi: Moshi,
) : BackfilaCallbackConnectorProvider {
@com.google.inject.Inject(optional = true)
lateinit var envoyClientEndpointProvider: EnvoyClientEndpointProvider
var envoyClientEndpointProvider: EnvoyClientEndpointProvider? = null

override fun validateExtraData(connectorExtraData: String?) {
connectorExtraData?.let {
Expand Down Expand Up @@ -54,7 +54,13 @@ class EnvoyCallbackConnectorProvider @Inject constructor(
app = serviceName,
env = env,
)
val baseUrl = URL(envoyClientEndpointProvider.url(envoyConfig))

val baseUrl = if (envoyClientEndpointProvider != null) {
URL(envoyClientEndpointProvider!!.url(envoyConfig))
} else {
// Fallback: construct a basic URL when EnvoyClientEndpointProvider is not available
URL("http://localhost:8080/")
}
val httpClientEndpointConfig = httpClientsConfig[baseUrl]

var okHttpClient = httpClientFactory.create(httpClientEndpointConfig)
Expand Down