-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Steps to reproduce:
- Add
<dist:module dist:instant="true"/>
to sample/app/main/AndroidManifest.xml - Change the run configuration for the sample app to "Deploy as an Instant App" and run
This then gives a configuration error for each dynamic feature module:
1: Task failed with an exception.
-----------
* What went wrong:
A problem was found with the configuration of task ':bigboxfeature:processDebugAndroidTestResources' (type 'LinkApplicationAndroidResourcesTask').
- In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask' property 'manifestFiles' doesn't have a configured value.
Reason: This property isn't marked as optional and no value has been configured.
Possible solutions:
1. Assign a value to 'manifestFiles'.
2. Mark property 'manifestFiles' as optional.
For more information, please refer to https://docs.gradle.org/8.2/userguide/validation_problems.html#value_not_set in the Gradle documentation.
I'm not actually sure this is related to BDF yet, but I'm able to do a pretty standard instant app build which fails if I apply BDF and all its related thing (ie this might be like a KSP issue)
I attempted to resolve by manually setting the manifestFiles
property for LinkApplicationAndroidResourcesTask
here
I also tried monkeypatching that task to make the property optional but it had so many internal references I got like 20 files of copying deep and decided it was probably not a workable solution
Even if this isn't a BDF issue, would be nice to fix it with BDF if we can
Metadata
Metadata
Assignees
Labels
No labels