Generate final test functions

Our two features didn't interact well.

Author: squarejesse

burst-gradle-plugin/src/test/kotlin/app/cash/burst/gradle/TestInterceptorGradlePluginTest.kt

@@ -211,4 +211,65 @@ class TestInterceptorGradlePluginTest {
       )
     }
   }
+
+  @Test
+  fun interceptorAndBurstConstructor() {
+    val tester = GradleTester("interceptorAndBurst")
+    tester.cleanAndBuild(":lib:test")
+
+    with(tester.readTestSuite("app.cash.burst.tests.InterceptorAndBurstConstructorTest_false")) {
+      assertThat(systemOut).isEqualTo(
+        """
+        |intercepting false test
+        |running false
+        |
+        """.trimMargin(),
+      )
+    }
+    with(tester.readTestSuite("app.cash.burst.tests.InterceptorAndBurstConstructorTest_true")) {
+      assertThat(systemOut).isEqualTo(
+        """
+        |intercepting true test
+        |running true
+        |
+        """.trimMargin(),
+      )
+    }
+  }
+
+  @Test
+  fun interceptorAndBurstFunction() {
+    val tester = GradleTester("interceptorAndBurst")
+    tester.cleanAndBuild(":lib:test")
+
+    with(tester.readTestSuite("app.cash.burst.tests.InterceptorAndBurstFunctionTest")) {
+      assertThat(systemOut).isEqualTo(
+        """
+        |intercepting function test_true
+        |running true
+        |intercepting function test_false
+        |running false
+        |
+        """.trimMargin(),
+      )
+    }
+  }
+
+  @Test
+  fun interceptorAndBurstSubclass() {
+    val tester = GradleTester("interceptorAndBurst")
+    tester.cleanAndBuild(":lib:test")
+
+    with(tester.readTestSuite("app.cash.burst.tests.InterceptorAndBurstSubclassTest")) {
+      assertThat(systemOut).isEqualTo(
+        """
+        |intercepting abstract test_true
+        |running subclass true
+        |intercepting abstract test_false
+        |running subclass false
+        |
+        """.trimMargin(),
+      )
+    }
+  }
 }

burst-gradle-plugin/src/test/projects/interceptorAndBurst/build.gradle.kts

@@ -0,0 +1,37 @@
+import org.jetbrains.kotlin.gradle.dsl.JvmTarget
+import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
+
+buildscript {
+  repositories {
+    maven {
+      url = file("$rootDir/../../../../../build/testMaven").toURI()
+    }
+    mavenCentral()
+    google()
+  }
+  dependencies {
+    classpath("app.cash.burst:burst-gradle-plugin:${project.property("burstVersion")}")
+    classpath(libs.kotlin.gradlePlugin)
+  }
+}
+
+allprojects {
+  repositories {
+    maven {
+      url = file("$rootDir/../../../../../build/testMaven").toURI()
+    }
+    mavenCentral()
+    google()
+  }
+
+  tasks.withType(JavaCompile::class.java).configureEach {
+    sourceCompatibility = "1.8"
+    targetCompatibility = "1.8"
+  }
+
+  tasks.withType(KotlinJvmCompile::class.java).configureEach {
+    compilerOptions {
+      jvmTarget.set(JvmTarget.JVM_1_8)
+    }
+  }
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/build.gradle.kts

@@ -0,0 +1,8 @@
+plugins {
+  kotlin("jvm")
+  id("app.cash.burst")
+}
+
+dependencies {
+  testImplementation(kotlin("test"))
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/src/test/kotlin/app/cash/burst/tests/BasicInterceptor.kt

@@ -0,0 +1,11 @@
+package app.cash.burst.tests
+
+import app.cash.burst.TestFunction
+import app.cash.burst.TestInterceptor
+
+class BasicInterceptor(val name: String) : TestInterceptor {
+  override fun intercept(testFunction: TestFunction) {
+    println("intercepting $name ${testFunction.functionName}")
+    testFunction()
+  }
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/src/test/kotlin/app/cash/burst/tests/InterceptorAndBurstAbstractTest.kt

@@ -0,0 +1,18 @@
+package app.cash.burst.tests
+
+import app.cash.burst.Burst
+import app.cash.burst.InterceptTest
+import kotlin.test.Test
+
+@Burst
+abstract class InterceptorAndBurstAbstractTest {
+  abstract val name: String
+
+  @InterceptTest
+  val interceptor = BasicInterceptor("abstract")
+
+  @Test
+  fun test(condition: Boolean) {
+    println("running $name $condition")
+  }
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/src/test/kotlin/app/cash/burst/tests/InterceptorAndBurstConstructorTest.kt

@@ -0,0 +1,18 @@
+package app.cash.burst.tests
+
+import app.cash.burst.Burst
+import app.cash.burst.InterceptTest
+import kotlin.test.Test
+
+@Burst
+class InterceptorAndBurstConstructorTest(
+  val condition: Boolean,
+) {
+  @InterceptTest
+  val interceptor = BasicInterceptor("$condition")
+
+  @Test
+  fun test() {
+    println("running $condition")
+  }
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/src/test/kotlin/app/cash/burst/tests/InterceptorAndBurstFunctionTest.kt

@@ -0,0 +1,16 @@
+package app.cash.burst.tests
+
+import app.cash.burst.Burst
+import app.cash.burst.InterceptTest
+import kotlin.test.Test
+
+@Burst
+class InterceptorAndBurstFunctionTest {
+  @InterceptTest
+  val interceptor = BasicInterceptor("function")
+
+  @Test
+  fun test(condition: Boolean) {
+    println("running $condition")
+  }
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/lib/src/test/kotlin/app/cash/burst/tests/InterceptorAndBurstSubclassTest.kt

@@ -0,0 +1,5 @@
+package app.cash.burst.tests
+
+class InterceptorAndBurstSubclassTest : InterceptorAndBurstAbstractTest() {
+  override val name = "subclass"
+}

burst-gradle-plugin/src/test/projects/interceptorAndBurst/settings.gradle.kts

@@ -0,0 +1,9 @@
+dependencyResolutionManagement {
+  versionCatalogs {
+    create("libs") {
+      from(files("../../../../../gradle/libs.versions.toml"))
+    }
+  }
+}
+
+include(":lib")

burst-kotlin-plugin/src/main/kotlin/app/cash/burst/kotlin/FunctionSpecializer.kt

@@ -16,6 +16,7 @@
 package app.cash.burst.kotlin
 
 import org.jetbrains.kotlin.backend.common.extensions.IrPluginContext
+import org.jetbrains.kotlin.descriptors.Modality
 import org.jetbrains.kotlin.ir.builders.declarations.buildFun
 import org.jetbrains.kotlin.ir.builders.declarations.buildReceiverParameter
 import org.jetbrains.kotlin.ir.builders.irCall
@@ -108,6 +109,7 @@ internal class FunctionSpecializer(
   ): IrSimpleFunction {
     val result = original.factory.buildFun {
       initDefaults(original)
+      modality = Modality.FINAL
       name = when {
         isDefaultSpecialization -> original.name
         else -> Name.identifier("${original.name.identifier}_${specialization.name}")