Skip to content

chore: Remove Deprecated APIs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2025
Merged

chore: Remove Deprecated APIs #98

merged 5 commits into from
Mar 28, 2025

Conversation

wsutina
Copy link
Contributor

@wsutina wsutina commented Mar 26, 2025 •
edited
Loading

Description

Based on the report from, https://github.com/cashapp/hermit-ij-plugin/actions/runs/13000725549/job/36258641212#step:4:163

Theres are Deprecated API Usages that need to be removed

  1. projectOpened(Project) – Method Override
  2. PerformInBackgroundOption

Changes

  1. Replace deprecated ProjectManagerListener.OpenProject with ProjectActivity as per doc

  2. Replace ProjectManagerListener.projectClosing with Disposable as per doc

  3. Remove deprecated PerformInBackgroundOption

    • Utilizes default Task.Backgroundable behavior which already uses ALWAYS_BACKGROUND

Testing

  • Verified project initialization still works correctly
  • Confirmed proper cleanup on project close
  • Tested background task execution behavior
  • The deprecate warning should be gone

wsutina added 3 commits March 26, 2025 17:54
@wsutina
chore: Replace decreated ProjectManagerListener.OpenProject with Proj…
ed4b64d 
…ectActivity

as per https://plugins.jetbrains.com/docs/intellij/plugin-components.html?_gl=1%2A19w0afu%2A_gcl_au%2AMTg1NDI5Nzc0Ny4xNzM3NjkzMzky%2AFPAU%2AMTg1NDI5Nzc0Ny4xNzM3NjkzMzky%2A_ga%2ANTIyNzM4NTg5LjE2OTcwMDQ1ODc.%2A_ga_9J976DJZ68%2AMTc0Mjk3MDQ2Ny44NC4wLjE3NDI5NzA0NjcuNjAuMC4w#project-open
@wsutina
chore: Remove projectClosing with Disposable
93a1d21 
as per https://plugins.jetbrains.com/docs/intellij/plugin-components.html?_gl=1%2A19w0afu%2A_gcl_au%2AMTg1NDI5Nzc0Ny4xNzM3NjkzMzky%2AFPAU%2AMTg1NDI5Nzc0Ny4xNzM3NjkzMzky%2A_ga%2ANTIyNzM4NTg5LjE2OTcwMDQ1ODc.%2A_ga_9J976DJZ68%2AMTc0Mjk3MDQ2Ny44NC4wLjE3NDI5NzA0NjcuNjAuMC4w#project-and-application-close
@wsutina
chore: Remove Deprecate PerformInBackgroundOption
9f3bb27 
Task.Backgrounable defaults to ALWAYS_BACKGROUND
https://github.com/JetBrains/intellij-community/blob/468d9bd86c6065a31d78bfbcc9bc08c0af80d07c/platform/core-api/src/com/intellij/openapi/progress/Task.java#L228
@wsutina wsutina merged commit ccee6a5 into main Mar 28, 2025
10 checks passed
@wsutina wsutina deleted the swipawiwat/remove-deprecated-api branch March 28, 2025 03:29
@wsutina wsutina mentioned this pull request Mar 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvmakine jvmakine jvmakine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsutina @jvmakine