fix(rust): auto version 'unknown variable ' bug and updates versions #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeyper
reviewed
Aug 11, 2025
mpeyper
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
Thanks for this.
FWIW, source + ".sha256" is already one of the standard locations hermit looks for sha256 sources, so removing the explicit sha256-source should be safe to do in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto version CI job was failing to update rust with this error:
fatal:hermit: rust.hcl: unknown variable $versionI believe I was able to fix this, and also added two missing versions, 1.88.0 and 1.89.0.