Skip to content

Commit 4772779

Browse files
committed
chore: remove BoltDB support
1 parent 0f3b2f3 commit 4772779

File tree

3 files changed

+1
-86
lines changed

3 files changed

+1
-86
lines changed

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ require (
2828
github.com/willabides/kongplete v0.3.0
2929
github.com/willdonnelly/passwd v0.0.0-20141013001024-7935dab3074c
3030
github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8
31-
go.etcd.io/bbolt v1.3.6
3231
golang.org/x/crypto v0.0.0-20220214200702-86341886e292
3332
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd
3433
golang.org/x/sys v0.0.0-20220209214540-3681064d5158

go.sum

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,6 @@ github.com/willdonnelly/passwd v0.0.0-20141013001024-7935dab3074c h1:4+NVyrLUuEm
101101
github.com/willdonnelly/passwd v0.0.0-20141013001024-7935dab3074c/go.mod h1:xcvfY9pOw6s4wyrhilFSbMthL6KzgrfCIETHHUOQ/fQ=
102102
github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8 h1:nIPpBwaJSVYIxUFsDv3M8ofmx9yWTog9BfvIu0q41lo=
103103
github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8/go.mod h1:HUYIGzjTL3rfEspMxjDjgmT5uz5wzYJKVo23qUhYTos=
104-
go.etcd.io/bbolt v1.3.6 h1:/ecaJf0sk1l4l6V4awd65v2C3ILy7MSj+s/x1ADCIMU=
105-
go.etcd.io/bbolt v1.3.6/go.mod h1:qXsaaIqmgQH0T+OPdb99Bf+PKfBBQVAdyD6TY9G8XM4=
106104
go.uber.org/goleak v1.1.10 h1:z+mqJhf6ss6BSfSM671tgKyZBFPTTJM+HLxnhPC3wu0=
107105
go.uber.org/goleak v1.1.10/go.mod h1:8a7PlsEVH3e/a/GLqe5IIrQx6GzcnRmZEufDUTk4A7A=
108106
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
@@ -123,7 +121,6 @@ golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJ
123121
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
124122
golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
125123
golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
126-
golang.org/x/sys v0.0.0-20200923182605-d9f96fdee20d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
127124
golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
128125
golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
129126
golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=

internal/dao/dao.go

Lines changed: 1 addition & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import (
66
"path/filepath"
77
"time"
88

9-
bolt "go.etcd.io/bbolt"
10-
119
"github.com/cashapp/hermit/errors"
1210
)
1311

@@ -41,7 +39,7 @@ func (d *DAO) Dump(w io.Writer) error {
4139
func (d *DAO) GetPackage(pkgRef string) (*Package, error) {
4240
r, err := os.Open(d.metadataPath(pkgRef))
4341
if os.IsNotExist(err) {
44-
return d.getPackageFromBBolt(pkgRef)
42+
return nil, nil
4543
}
4644
if err != nil {
4745
return nil, errors.WithStack(err)
@@ -77,82 +75,3 @@ func (d *DAO) DeletePackage(pkgRef string) error {
7775
func (d *DAO) metadataPath(pkgRef string) string {
7876
return filepath.Join(d.metadataDir, pkgRef+".etag")
7977
}
80-
81-
// TODO: Remove this BBolt code.
82-
83-
func (d *DAO) db(readonly bool) (*bolt.DB, error) {
84-
path := filepath.Join(d.stateDir, "hermit.bolt.db")
85-
db, err := bolt.Open(path, 0600, &bolt.Options{
86-
Timeout: 5 * time.Second,
87-
ReadOnly: readonly,
88-
})
89-
if err != nil {
90-
return nil, errors.Wrapf(err, "failed to open Hermit state database: %s", path)
91-
}
92-
return db, nil
93-
}
94-
95-
func (d *DAO) view(fn func(tx *bolt.Tx) error) error {
96-
db, err := d.db(true)
97-
if err != nil {
98-
return errors.WithStack(err)
99-
}
100-
defer db.Close()
101-
102-
return errors.WithStack(db.View(fn))
103-
}
104-
105-
func (d *DAO) getPackageFromBBolt(name string) (*Package, error) {
106-
var pkg *Package
107-
err := d.view(func(tx *bolt.Tx) error {
108-
b := tx.Bucket([]byte(name))
109-
pkg = packageAt(b)
110-
return nil
111-
})
112-
if err != nil {
113-
return nil, errors.WithStack(err)
114-
}
115-
return pkg, nil
116-
}
117-
118-
const (
119-
updateCheckedAtKey = "updateCheckedAt"
120-
eTagKey = "etag"
121-
timeformat = time.RFC3339
122-
)
123-
124-
func stringAt(bucket *bolt.Bucket, name string) string {
125-
if bucket == nil {
126-
return ""
127-
}
128-
bytes := bucket.Get([]byte(name))
129-
if bytes == nil {
130-
return ""
131-
}
132-
return string(bytes)
133-
}
134-
135-
func timeAt(bucket *bolt.Bucket, name string) time.Time {
136-
if bucket == nil {
137-
return time.Time{}
138-
}
139-
bytes := bucket.Get([]byte(name))
140-
if bytes == nil {
141-
return time.Time{}
142-
}
143-
t, err := time.Parse(timeformat, string(bytes))
144-
if err != nil {
145-
return time.Time{}
146-
}
147-
return t
148-
}
149-
150-
func packageAt(b *bolt.Bucket) *Package {
151-
if b == nil {
152-
return nil
153-
}
154-
return &Package{
155-
Etag: stringAt(b, eTagKey),
156-
UpdateCheckedAt: timeAt(b, updateCheckedAtKey),
157-
}
158-
}

0 commit comments

Comments
 (0)