Skip to content

Commit ee61a3a

Browse files
authored
Merge pull request #298 from cashapp/skorulis/assembly-id
Use ObjectIdentifier for assembly unique check
2 parents 6fc3bc1 + 75bd3c4 commit ee61a3a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Sources/Knit/Module/DependencyBuilder.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,19 +41,19 @@ final class DependencyBuilder {
4141
let toAssemble = assemblyCache.toAssemble
4242

4343
// Instantiate all types
44-
var createdTypes = Set<String>()
44+
var createdTypes = Set<ObjectIdentifier>()
4545
for ref in toAssemble {
4646
guard !self.isRegisteredInParent(ref) else {
4747
continue
4848
}
4949
let assembly = try instantiate(moduleType: ref.type)
5050
// Ensure the same assembly isn't added twice
51-
let typeName = String(describing: type(of: assembly))
52-
guard !createdTypes.contains(typeName) else {
51+
let typeId = ObjectIdentifier(type(of: assembly))
52+
guard !createdTypes.contains(typeId) else {
5353
continue
5454
}
5555
assemblies.append(assembly)
56-
createdTypes.insert(typeName)
56+
createdTypes.insert(typeId)
5757
}
5858
}
5959

0 commit comments

Comments
 (0)