Force strict abstract assemblies #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
changed the title
skorulis-ap
force-pushed
the
skorulis/strict-abstract-error
branch
from
f2c1121 to
1e723fa
Compare
bradfol
approved these changes
Aug 13, 2025
Comment on lines
-68
to
-69
| @Flag(help: "When true, only abstract modules will be allowed to contain abstract registrations") | ||
| var strictAbstract: Bool = false |
Comment on lines
+21
to
+26
| fileprivate var supportedFunctions: [Registration.FunctionName] { | ||
| switch self { | ||
| case .abstractAssembly: | ||
| return [.registerAbstract] | ||
| case .moduleAssembly, .autoInitAssembly, .fakeAssembly: | ||
| return [.implements, .register] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I implemented this the first time helped to cleanup cash-ios but it didn't do a good job of surfacing the errors in a friendly way. This version raises errors in the same pathway for the
nonAbstracterror.I realised that there are significant performance benefits possible by enforcing splitting out abstract assemblies so I got rid of it as a configurable parameter to allow deleting the replacement code in a future PR.