Skip to content

Use ObjectIdentifier for assembly unique check #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Use ObjectIdentifier for assembly unique check #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/Knit/Module/DependencyBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ final class DependencyBuilder {
let toAssemble = assemblyCache.toAssemble

// Instantiate all types
var createdTypes = Set<String>()
var createdTypes = Set<ObjectIdentifier>()
for ref in toAssemble {
guard !self.isRegisteredInParent(ref) else {
continue
}
let assembly = try instantiate(moduleType: ref.type)
// Ensure the same assembly isn't added twice
let typeName = String(describing: type(of: assembly))
guard !createdTypes.contains(typeName) else {
let typeId = ObjectIdentifier(type(of: assembly))
guard !createdTypes.contains(typeId) else {
continue
}
assemblies.append(assembly)
createdTypes.insert(typeName)
createdTypes.insert(typeId)
}
}

Expand Down
Loading