Fix build issues when MemberImportVisibility is enabled #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/swinject-import
branch
from
414a94d to
57d8f60
Compare
skorulis-ap
changed the title
jszumski
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project uses the
MemberImportVisibilitycompiler flag then it requires that Swinject is imported in order to access functions from Swinject, like.implements. To a large degree this would require all consumers of Knit to also import Swinject. To solve this I've added@_exported import Swinject.But now that Swinject is always imported there will be constant conflicts between the Container and Resolver types. So I've renamed the Swinject versions to
SwinjectContainerandSwinjectResolver