Fix HibernateModule installSchemaMigrator issue that prevents

ServiceManager creation

GitOrigin-RevId: 4476c19873e2879e5621cc78403be3307c376837

Author: aparajon

misk-hibernate/src/main/kotlin/misk/hibernate/HibernateModule.kt

@@ -171,11 +171,14 @@ open class HibernateModule @JvmOverloads constructor(
 
     val transacterKey = Transacter::class.toKey(qualifier)
 
-    install(
-      ServiceModule<SchemaMigratorService>(qualifier)
-        .dependsOn<DataSourceService>(qualifier)
-        .enhancedBy<ReadyService>()
-    )
+    // Only install SchemaMigratorService module if schema migrator is enabled
+    if (installSchemaMigrator) {
+      install(
+        ServiceModule<SchemaMigratorService>(qualifier)
+          .dependsOn<DataSourceService>(qualifier)
+          .enhancedBy<ReadyService>()
+      )
+    }
 
     bind(transacterKey).toProvider(getTransacterProvider()).asSingleton()
 
@@ -291,12 +294,16 @@ open class HibernateModule @JvmOverloads constructor(
     }.asSingleton()
 
     if (isWriter) {
-      install(
-        ServiceModule<TransacterService>(qualifier)
-          .enhancedBy<SchemaMigratorService>(qualifier)
-          .enhancedBy<ReadyService>()
-          .dependsOn<DataSourceService>(qualifier)
-      )
+      val transacterServiceModule = ServiceModule<TransacterService>(qualifier)
+        .dependsOn<DataSourceService>(qualifier)
+        .enhancedBy<ReadyService>()
+      
+      // Only enhance with SchemaMigratorService if it's installed
+      if (installSchemaMigrator) {
+        install(transacterServiceModule.enhancedBy<SchemaMigratorService>(qualifier))
+      } else {
+        install(transacterServiceModule)
+      }
     } else {
       install(
         ServiceModule<TransacterService>(qualifier)

misk-hibernate/src/test/kotlin/misk/hibernate/HibernateModuleInstallSchemaMigratorTest.kt

@@ -1,5 +1,6 @@
 package misk.hibernate
 
+import com.google.common.util.concurrent.ServiceManager
 import com.google.inject.Guice
 import com.google.inject.Key
 import com.google.inject.util.Modules
@@ -88,6 +89,36 @@ internal class HibernateModuleInstallSchemaMigratorTest {
     assertThat(exception.message).contains("No implementation for")
     assertThat(exception.message).contains("SchemaMigratorService")
   }
+
+  @Test
+  fun `installSchemaMigrator=false should allow ServiceManager to be created`() {
+    val module = Modules.combine(
+      deploymentModule,
+      MiskTestingServiceModule(),
+      HibernateModule(
+        qualifier = TestDb::class,
+        config = dataSourceConfig,
+        readerQualifier = null,
+        readerConfig = null,
+        installSchemaMigrator = false
+      ),
+      object : HibernateEntityModule(TestDb::class) {
+        override fun configureHibernate() {
+          addEntities(DbMovie::class)
+        }
+      }
+    )
+
+    val injector = Guice.createInjector(module)
+
+    // ServiceManager should be created successfully without SchemaMigratorService
+    val serviceManager = injector.getInstance(ServiceManager::class.java)
+    assertThat(serviceManager).isNotNull()
+    
+    // DataSourceService should still be bound
+    val dataSourceService = injector.getInstance(Key.get(DataSourceService::class.java, TestDb::class.java))
+    assertThat(dataSourceService).isInstanceOf(DataSourceService::class.java)
+  }
 }
 
 @com.google.inject.BindingAnnotation