Add ability to avoid recording if difference threshold not exceeded #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatoslav-starkov
changed the title
|
@geoff-powell Is there any chance this functionality will be added in the near future? It’s something that’s really missing when using Paparazzi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a boolean flag to use
maxPercentDifferenceforrecordPaparazzicommand.Not sure if it should be a boolean flag or a separate double type to set a different
maxPercentDifferencefor record only.Also, uncertain about API compatibility with the changes I introduced.
The problem with different operating systems that I described here is no longer reproducible in either direction (Mac/Windows). For AGP updates or other things that could have caused problems, this fix should work as well.
Closes #1951