Cleanup and fix OOM for SIFT differ #2085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-powell
commented
Sep 3, 2025
Comment on lines
141
to
151
| private fun subtractImagesInPlace(a: Array<DoubleArray>, b: Array<DoubleArray>): Array<DoubleArray> { | ||
| val h = a.size | ||
| val w = a[0].size | ||
| val result = Array(h) { DoubleArray(w) } | ||
| for (y in 0 until h) { | ||
| for (x in 0 until w) { | ||
| result[y][x] = a[y][x] - b[y][x] | ||
| } | ||
| // Modify 'a' in place | ||
| for (y in 0 until h) for (x in 0 until w) { | ||
| a[y][x] -= b[y][x] | ||
| } | ||
| return result | ||
| return a // Return the modified 'a' | ||
| } |
There was a problem hiding this comment.
Instead of allocating a new Array> of an image we just alter the existing array
geoff-powell
commented
Sep 3, 2025
| with(siftResult2) { | ||
| assertThat(this).isInstanceOf(DiffResult.Similar::class.java) | ||
| this as DiffResult.Similar | ||
| assertThat(numSimilarPixels).isEqualTo(635) |
There was a problem hiding this comment.
the num of pixels diff was 635 and not 293
geoff-powell
force-pushed
the
gpowell/fix-sift-oom
branch
3 times, most recently
from
53a5d59 to
717ae06
Compare
geoff-powell
force-pushed
the
gpowell/fix-sift-oom
branch
from
717ae06 to
d81d81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.