Skip to content

Commit 906c4dd

Browse files
authored
macOS 15, iPhone 16, iOS 18.4 on CI (#2776)
Re-record all snapshots, which contain mostly subtle text hinting differences. Also added validation of the widget module which was not being run on CI.
1 parent 857a060 commit 906c4dd

File tree

184 files changed

+388
-370
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

184 files changed

+388
-370
lines changed

.github/workflows/build.yaml

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
if-no-files-found: error
132132

133133
screenshot-tests:
134-
runs-on: macos-14
134+
runs-on: macos-latest
135135
steps:
136136
- uses: actions/checkout@v5
137137
with:
@@ -144,9 +144,15 @@ jobs:
144144

145145
- run: ./gradlew verifyPaparazzi
146146

147-
- run: xcodebuild -project redwood-layout-uiview/RedwoodLayoutUIViewTests.xcodeproj -scheme RedwoodLayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5' test
147+
- uses: maxim-lobanov/setup-xcode@v1
148+
with:
149+
xcode-version: '16.4'
150+
151+
- run: xcodebuild -project redwood-layout-uiview/RedwoodLayoutUIViewTests.xcodeproj -scheme RedwoodLayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4' test
152+
153+
- run: xcodebuild -project redwood-lazylayout-uiview/RedwoodLazylayoutUIViewTests.xcodeproj -scheme RedwoodLazylayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4' test
148154

149-
- run: xcodebuild -project redwood-lazylayout-uiview/RedwoodLazylayoutUIViewTests.xcodeproj -scheme RedwoodLazylayoutUIViewTests -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5' test
155+
- run: xcodebuild -project redwood-widget-uiview-test/RedwoodWidgetUIViewTests.xcodeproj -scheme RedwoodWidgetUIViewTests -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4' test
150156

151157
- uses: actions/upload-artifact@v4
152158
if: ${{ always() }}
@@ -169,7 +175,7 @@ jobs:
169175
- run: ./gradlew :redwood-treehouse-host:check
170176

171177
sample-counter:
172-
runs-on: macos-14
178+
runs-on: macos-latest
173179
steps:
174180
- uses: actions/checkout@v5
175181
- uses: actions/setup-java@v5
@@ -180,8 +186,12 @@ jobs:
180186

181187
- run: ./gradlew -p samples/counter build
182188

189+
- uses: maxim-lobanov/setup-xcode@v1
190+
with:
191+
xcode-version: '16.4'
192+
183193
- name: Build Counter iOS (UIKit)
184-
run: xcodebuild -project samples/counter/ios-uikit/CounterApp.xcodeproj -scheme CounterApp -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest'
194+
run: xcodebuild -project samples/counter/ios-uikit/CounterApp.xcodeproj -scheme CounterApp -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'
185195

186196
sample-counter-emulator:
187197
runs-on: ubuntu-latest
@@ -206,7 +216,7 @@ jobs:
206216
script: ./gradlew -p samples/counter connectedCheck
207217

208218
sample-emoji:
209-
runs-on: macos-14
219+
runs-on: macos-latest
210220
steps:
211221
- uses: actions/checkout@v5
212222
- uses: actions/setup-java@v5
@@ -217,8 +227,12 @@ jobs:
217227

218228
- run: ./gradlew -p samples/emoji-search build
219229

230+
- uses: maxim-lobanov/setup-xcode@v1
231+
with:
232+
xcode-version: '16.4'
233+
220234
- name: Build Emoji Search iOS (UIKit)
221-
run: xcodebuild -project samples/emoji-search/ios-uikit/EmojiSearchApp.xcodeproj -scheme EmojiSearchApp -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest'
235+
run: xcodebuild -project samples/emoji-search/ios-uikit/EmojiSearchApp.xcodeproj -scheme EmojiSearchApp -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'
222236

223237
#sample-emoji-emulator:
224238
# runs-on: ubuntu-latest
@@ -243,7 +257,7 @@ jobs:
243257
# script: ./gradlew -p samples/emoji-search connectedCheck
244258

245259
test-app:
246-
runs-on: macos-14
260+
runs-on: macos-latest
247261
steps:
248262
- uses: actions/checkout@v5
249263
- uses: actions/setup-java@v5
@@ -254,8 +268,12 @@ jobs:
254268

255269
- run: ./gradlew -p test-app build
256270

271+
- uses: maxim-lobanov/setup-xcode@v1
272+
with:
273+
xcode-version: '16.4'
274+
257275
- name: Build TestApp iOS (UIKit)
258-
run: xcodebuild -project test-app/ios-uikit/TestApp.xcodeproj -scheme TestApp -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest'
276+
run: xcodebuild -project test-app/ios-uikit/TestApp.xcodeproj -scheme TestApp -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4'
259277

260278
final-status:
261279
if: ${{ !cancelled() }}
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)