Add iOS change list renderer tests #1197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
approved these changes
Jun 12, 2023
swankjesse
reviewed
Jun 12, 2023
|
|
||
| class DefaultExampleSchemaWidgetFactory : ExampleSchemaWidgetFactory<UIView> { | ||
| override fun Row(): Row<UIView> = RowBinding() | ||
| override fun ScopedRow(): ScopedRow<UIView> = TODO("Not yet implemented") |
There was a problem hiding this comment.
We MIGHT want to change these to error("unexpected call") because I think there’s a robot that creates GitHub issues for all of our TODOs in this repo. I don’t think we ever want to actually do this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.