Stop configuring the max width and height in YogaUIView #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes only cause us pain. In particular they aren't necessary to pass any of our layout tests, and by removing them I can fix a layout bug. Note that on Android we do not use these attributes, so this brings the two platforms closer together. Closes: #2753
dnagler
approved these changes
Aug 22, 2025
|
You might need to use an older simulator to generate the snapshot because of the GitHub runner debacle. I can upgrade us to macOS 15, Xcode 16.4, and iOS 18.4 next week. |
|
Or just |
This way we can tell the view whether a measurement is exactly (which it should honor unconditionally), or not (which it might honor if its constraint is Fill).
JakeWharton
reviewed
Aug 22, 2025
|
Until I do the switch, I was able to generate new screenshots for my PR by switching to Xcode 15.4 and using iOS 17.5 as the simulator. |
|
I generated the screenshots okay on my Mac. |
|
I think something with text hinting changed in iOS 18 so when we bump lots of the goldens change. I had to roll back to Xcode 15.4 and iOS 17.5 for mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes only cause us pain.
In particular they aren't necessary to pass any of our layout tests, and by removing them I can fix a layout bug.
Note that on Android we do not use these attributes, so this brings the two platforms closer together.
Closes: #2753
CHANGELOG.md's "Unreleased" section has been updated, if applicable.