Verify snapshot #2773
Merged
Verify snapshot #2773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rqcai
force-pushed
the
rcai_verify_snapshot
branch
from
361381e to
6a1b191
Compare
JakeWharton
approved these changes
Aug 25, 2025
redwood-dom-testing/src/commonMain/kotlin/app/cash/redwood/dom/testing/DomSnapshotter.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private suspend fun Blob.contentEquals(other: Blob): Boolean { |
There was a problem hiding this comment.
We may have to implement more advanced strategies in the future if the variation across machines turns out to be a problem. Something like https://zschuessler.github.io/DeltaE/ maybe.
…/testing/DomSnapshotter.kt Co-authored-by: Jake Wharton <jw@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.