Revert a bunch of widget subclass splits from 'layout' #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.bindings.2025-08-25
branch
2 times, most recently
from
a48b8a7 to
c3d4962
Compare
This reverts commit 5add09a.
JakeWharton
force-pushed
the
jw.bindings.2025-08-25
branch
from
c3d4962 to
0672c5e
Compare
|
There's actually one more to revert in the 'layout' schema, but it's very messy so I'll probably do that some other time. |
squarejesse
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was when we thought we could use
abstract classes forWidgets (#2231), which we cannot. Re-combining these saves a tiny bit of memory.CHANGELOG.md's "Unreleased" section has been updated, if applicable.