Consistently frame the target element #2799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need it in each project we do snapshot testing in, but I'm unaware of a way to load it from anywhere but the current project's directory.
rqcai
approved these changes
Sep 9, 2025
redwood-dom-testing/src/commonMain/kotlin/app/cash/redwood/dom/testing/DomSnapshotter.kt
Outdated
Show resolved
Hide resolved
JakeWharton
approved these changes
Sep 9, 2025
| /** | ||
| * Configure the canvas that we will snapshot our element on. | ||
| */ | ||
| public class Frame( |
There was a problem hiding this comment.
Hmm I don't think this should live here. Or at least should immediately move after merging.
I think this should live in the shared test infrastructure so that each abstract test class can define their default frame (or even per-snapshot frames). This results in each platform producing images that are the same size and (should) look the same.
There was a problem hiding this comment.
Fantastic idea. Will do in follow-up.
...d-dom-testing/src/commonTest/kotlin/app/cash/redwood/dom/testing/DomSnapshotterSampleTest.kt
Outdated
Show resolved
Hide resolved
Support a target element that isn't already a child of the document's root element. When snapshotting, wrap the element in a frame, and then remove the element from that frame afterwards. This avoids mutating the passed-in element as a side-effect of snapshotting.
swankjesse
force-pushed
the
jwilson.0909.fixup_frames
branch
from
9b8fb11 to
02c816a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a target element that isn't already a child of the document's root element.
When snapshotting, wrap the element in a frame, and then remove the element from that frame afterwards. This avoids mutating the passed-in element as a
side-effect of snapshotting.