Bump deployment target to iOS 15 #81
Conversation
There was a problem hiding this comment.
LGTM under the assumption that the next release is a breaking change. with some blocking comments. My guess is that we want to move to swift v5.10 everywhere except the swift package version, with a possible intent to move to Swift 6 soonish (though once you only support Xcode 16, moving to swift 6 might not be a breaking change).
Sidebar: TIL that the minimum supported version is iOS 15 now. I gotta go update a few of my repos 😅
| @@ -719,7 +719,7 @@ | |||
| DEBUG_INFORMATION_FORMAT = dwarf; | |||
| GCC_C_LANGUAGE_STANDARD = gnu11; | |||
| INFOPLIST_FILE = "Performance Tests/Info.plist"; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 12.2; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 15.6; | |||
| @@ -7,7 +7,7 @@ Pod::Spec.new do |s| | |||
| s.author = 'Square' | |||
| s.source = { :git => 'https://github.com/CashApp/Stagehand.git', :tag => s.version.to_s } | |||
|
|
|||
| s.ios.deployment_target = '12.0' | |||
| s.ios.deployment_target = '15.0' | |||
|
|
|||
| s.swift_version = '5.0.1' | |||
There was a problem hiding this comment.
We likely want 5.10 or 6.0 here
| @@ -21,7 +21,7 @@ import PackageDescription | |||
| let package = Package( | |||
There was a problem hiding this comment.
We likely want to change the swift tools version to 6.0 at the top of the file, and remove the stray let version line at the bottom of this file
| @@ -21,7 +21,7 @@ import PackageDescription | |||
| let package = Package( | |||
| name: "Stagehand", | |||
| platforms: [ | |||
| .iOS(.v12), | |||
| .iOS(.v15), | |||
| .macOS(.v11), | |||
| ], | |||
| products: [ | |||
There was a problem hiding this comment.
Do we want the swift version of this repo to be 5 or 6? I know we want to support SPM v6, but what language mode do we want for this repo? Are we ready for 6? Or is there more work to do first?
| @@ -7,7 +7,7 @@ Pod::Spec.new do |s| | |||
| s.author = 'Square' | |||
| s.source = { :git => 'https://github.com/CashApp/Stagehand.git', :tag => s.version.to_s } | |||
|
|
|||
| s.ios.deployment_target = '12.0' | |||
| s.ios.deployment_target = '15.0' | |||
|
|
|||
| s.swift_version = '5.0.1' | |||
With the release of Xcode 16 the furthest back you can deploy an app is iOS 15, so there's no real point in supporting prior to that.