Support CoroutineScope without a Job in testIn #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most `CoroutineScope`s contain a `Job`, and should contain a `Job` to work with structured concurrency. However, some `CoroutineScope`s do not have a `Job` (`GlobalScope` is an example). This change adds support for `CoroutineScope`s with no `Job` to Turbine's `testIn` function, which previously would throw `IllegalStateException` if called with such a `CoroutineScope`. A `CoroutineScope` with no `Job` never completes, so a call to `invokeOnCompletion` is not needed in that case.
|
Thanks! A bit weird, but I don't see a reason we need to take a stand on this. |
|
Thanks for the quick merge. :) |
|
This is now released in 1.2.1, FYI |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
CoroutineScopes contain aJob, and should contain aJobto work with structured concurrency. However, someCoroutineScopes do not have aJob(GlobalScopeis an example).This change adds support for
CoroutineScopes with noJobto Turbine'stestInfunction, which previously would throwIllegalStateExceptionif called with such aCoroutineScope.A
CoroutineScopewith noJobnever completes, so a call toinvokeOnCompletionis not needed in that case.CHANGELOG.md's "Unreleased" section has been updated, if applicable.