Patch for StackOverflow on Recursive Class Definitions. #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Aug 13, 2024
| assertEquals( | ||
| expected = "SomeType<" + | ||
| "app.cash.zipline.internal.bridge.SomeRecursiveType<" + | ||
| "app.cash.zipline.internal.bridge.SomeRecursiveType?<app.cash.zipline.internal.bridge.SomeRecursiveType?>" + |
There was a problem hiding this comment.
I'm wondering if it's necessary to include the second copy here. If we break before recursing it won't be included, and isn't it entirely redundant?
There was a problem hiding this comment.
@JakeWharton you are correct, it does exit, in above:
- 1st serialName of Non-Nullable
SomeRecursiveType. - 1st serialName of Nullable
SomeRecursiveType. - 2nd Recurse serialName of Nullable
SomeRecursiveType, hence exits with plain serialName of descriptor.
There was a problem hiding this comment.
Right my question was if the second copy is actually necessary or redundant
There was a problem hiding this comment.
AhUnderstood what you mean,
Yes we could just return empty string once we hit recursion instead of repeating serialName, shouldn't matter.
zipline/src/commonMain/kotlin/app/cash/zipline/internal/bridge/ZiplineServiceAdapter.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jake Wharton <github@jakewharton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall Fix #1163.
PS: