Add compile subcommand to zipline-cli #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.cli-compile.2024-09-06
branch
4 times, most recently
from
90d4547 to
63be40f
Compare
Update Gradle plugin to invoke CLI to perform compilation. This allows compilation to not be subject to the version of Kotlin on the Gradle buildscript classpath.
JakeWharton
force-pushed
the
jw.cli-compile.2024-09-06
branch
from
63be40f to
404c135
Compare
swankjesse
reviewed
Sep 9, 2024
| } | ||
| .multiple() | ||
|
|
||
| private val metadata by option().associate() |
There was a problem hiding this comment.
This API is so powerful
swankjesse
reviewed
Sep 9, 2024
| stripLineNumbers = stripLineNumbers, | ||
| ) | ||
|
|
||
| if (addedFiles.size or removedFiles.size or modifiedFiles.size != 0) { |
There was a problem hiding this comment.
is this bitwise or ? Sneaky! I’d complain but it passes the less-code test
There was a problem hiding this comment.
Yep. The normal isNotEmpty and boolean conditionals wrapped and it annoyed me so... I figure it's only in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Gradle plugin to invoke CLI to perform compilation. This allows compilation to not be subject to the version of Kotlin on the Gradle buildscript classpath.
Should unblock #1420