WIP Sonar

Author: Lomilar

src/main/server/adapter/asn/asn.js

@@ -126,7 +126,7 @@ cfClean = function (o) {
     }
 
     var ordered = {};
-    Object.keys(o).sort().forEach(function (key) {
+    Object.keys(o).sort().forEach(function (key) { // NOSONAR - Programmatic sort is necessary
         ordered[key] = o[key];
         delete o[key];
     });
@@ -137,12 +137,12 @@ cfClean = function (o) {
 }
 
 /*Errors:
-400 - An invalid selection field was supplied and data filtering on the selection criteria was not possible i.e. 'invalid_selection_field'. This is accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
-401 - The request was not correctly authorised i.e. 'unauthorisedrequest'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
-403 - This is used to indicate that the server can be reached and process the request but refuses to take any further action i.e. 'forbidden'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
-404 - Either the supplied identifier is unknown in the Service Provider and so the object could not be changed or an invalid UUID has been supplied. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The statement 'Unknown Object' of 'Invalid UUID' should also be presented. The payload structure is defined by the structure imsx_StatusInfo.Type.
-429 - The server is receiving too many requests i.e. 'server_busy'. Retry at a later time. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
-500 - This code should be used only if there is catastrophic error and there is not a more appropriate code i.e. 'internal_server_error'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    400 - An invalid selection field was supplied and data filtering on the selection criteria was not possible i.e. 'invalid_selection_field'. This is accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    401 - The request was not correctly authorised i.e. 'unauthorisedrequest'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    403 - This is used to indicate that the server can be reached and process the request but refuses to take any further action i.e. 'forbidden'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    404 - Either the supplied identifier is unknown in the Service Provider and so the object could not be changed or an invalid UUID has been supplied. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The statement 'Unknown Object' of 'Invalid UUID' should also be presented. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    429 - The server is receiving too many requests i.e. 'server_busy'. Retry at a later time. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
+    500 - This code should be used only if there is catastrophic error and there is not a more appropriate code i.e. 'internal_server_error'. This would be accompanied by the 'codeMajor/severity' values of 'failure/error'. The payload structure is defined by the structure imsx_StatusInfo.Type.
 */
 cfDocuments = async function (f, terms) {
     f = await cfGetFramework.call(this, f);

src/main/server/adapter/case/caseAdapter.js

@@ -5,13 +5,10 @@
 //      https://docs.google.com/document/d/1w_0HDNIA9GZq76txOuS8e-OhmKJiHe9Azjuq1BfrxQ0/edit
 
 async function pnaEndpoint() {
-
-    EcRepository.cache = new Object();
+    EcRepository.cache = {};
     EcRepository.caching = true;
-    if (false && repoEndpoint().contains("localhost"))
-        error("Endpoint Configuration is not set.", 500);
-    var query = queryParse.call(this);
-    var framework = null;
+    let query = queryParse.call(this);
+    let framework = null;
     if (framework == null)
         framework = await skyrepoGet.call(this, query);
 
@@ -27,7 +24,7 @@ async function pnaEndpoint() {
     }
 
     // Data from the framework to be stored in Competency Explorer registry for indexing
-    let pnaData = new Object();
+    let pnaData = {};
 
     const now = new Date();
     const formattedNow = now.getFullYear() + "-" + (now.getMonth() + 1) + "-" + now.getDate();
@@ -60,23 +57,24 @@ async function pnaEndpoint() {
         name: framework["name"],
         description: framework["description"],
         attributionName: attribution.startsWith('http') ? "" : attribution,
-        attributionURL:  attribution.startsWith('http') ? attribution : "",
+        attributionURL: attribution.startsWith('http') ? attribution : "",
         beneficiaryRights: framework["ceasn:license"] ? framework["ceasn:license"] : (framework["schema:license"] ? framework["schema:license"] : ""),
         dataURL: ceasnEndpointFramework + query["id"],
-        providerMetaModel: process.env.PNA_PROVIDER_META_MODEL ?process.env. PNA_PROVIDER_META_MODEL : "",
+        providerMetaModel: process.env.PNA_PROVIDER_META_MODEL ? process.env.PNA_PROVIDER_META_MODEL : "",
         registryRights: process.env.PNA_REGISTRY_RIGHTS ? process.env.PNA_REGISTRY_RIGHTS : "",
     };
-    
+
     if (framework.competency == null) framework.competency = [];
 
     let competencies = [];
     const promises = [];
-    framework.competency.forEach(cid => {
+    framework.competency.forEach((cid) => {
         promises.push(EcRepository.get(
-        EcRemoteLinkedData.trimVersionFromUrl(cid),
-        null,
-        null,
-        repo).then((expanded) => {
+            EcRemoteLinkedData.trimVersionFromUrl(cid),
+            null,
+            null,
+            repo
+        ).then((expanded) => {
             if (expanded && expanded["id"]) {
                 match = expanded["id"].match('(.*)(\/data\/)(.*)');
                 let ceasnEndpoint = match && match.length > 1 ? match[1] + "/ceasn/" : undefined;
@@ -108,12 +106,11 @@ async function pnaEndpoint() {
         return JSON.stringify(result);
     } else {
         return JSON.stringify(pnaData);
-    }    
+    }
 }
 
 async function uploadToAws(data, name) {
-
-    const { S3Client, PutObjectCommand } = require("@aws-sdk/client-s3");
+    const {S3Client, PutObjectCommand} = require("@aws-sdk/client-s3");
 
     const AWS_REGION = process.env.PNA_AWS_REGION ? process.env.PNA_AWS_REGION : "";
     const AWS_BUCKET = process.env.PNA_AWS_BUCKET ? process.env.PNA_AWS_BUCKET : "";
@@ -127,14 +124,14 @@ async function uploadToAws(data, name) {
             return {
                 framework: undefined,
                 success: false
-            };    
+            };
         }
         if (!AWS_REGION) {
             global.auditLogger.report(global.auditLogger.LogCategory.ADAPTER, global.auditLogger.Severity.ERROR, "pnaUploadErr", 'No AWS Region provided');
             return {
                 framework: name,
                 success: false
-            };    
+            };
         }
         if (!AWS_BUCKET) {
             global.auditLogger.report(global.auditLogger.LogCategory.ADAPTER, global.auditLogger.Severity.ERROR, "pnaUploadErr", 'No AWS Bucket provided');
@@ -181,7 +178,7 @@ async function uploadToAws(data, name) {
         return {
             framework: name,
             success: success
-        };    
+        };
     } catch (err) {
         global.auditLogger.report(global.auditLogger.LogCategory.ADAPTER, global.auditLogger.Severity.ERROR, "pnaUploadErr", name);
         global.auditLogger.report(global.auditLogger.LogCategory.ADAPTER, global.auditLogger.Severity.ERROR, "pnaUploadErr", err);