Version identifier #1383
Merged
Version identifier #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (range.toLowerCase().indexOf("level") !== -1 && this.profile[property]["add"] !== "checkedOptions") { | ||
| return false; | ||
| } | ||
| if (range.toLowerCase().indexOf("https://purl.org/ctdl/terms/IdentifierValue") !== -1) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 months ago
To fix the issue, the code should parse the range value as a URL and validate its host explicitly. This ensures that the substring check is performed on the correct part of the URL and prevents malicious URLs from bypassing the validation. The URL class in JavaScript can be used to parse the URL and extract its host for comparison.
The fix involves:
- Parsing the
rangevalue using theURLclass. - Validating the host of the parsed URL against a whitelist or ensuring it matches the expected domain.
- Replacing the substring check with a more robust host-based validation.
Suggested changeset
1
src/lode/components/AddProperty.vue
| @@ -550,4 +550,10 @@ | ||
| } | ||
| if (range.toLowerCase().indexOf("https://purl.org/ctdl/terms/IdentifierValue") !== -1) { | ||
| return false; | ||
| try { | ||
| const parsedUrl = new URL(range); | ||
| const allowedHost = "purl.org"; | ||
| if (parsedUrl.host !== allowedHost || !parsedUrl.pathname.startsWith("/ctdl/terms/IdentifierValue")) { | ||
| return false; | ||
| } | ||
| } catch (e) { | ||
| return false; // Invalid URL | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.