fix(reddit): trending carousel cards text#2114
Conversation
|
Can I see a screenshot of these elements before and after? And can you clarify where these elements are meant to be? I've been poking around the site while both logged in and not and haven't seen this issue. |
|
I still can't locate those cards on my Reddit page, is this something I need to configure/enable/toggle in settings? |
|
I think the issue is that your signed in. This is what reddit.com looks like for users that aren't signed in or using any extensions for modification. |
|
Ah thanks I opened in a new clean window and reproduced. |
|
Can we try setting |
Set --color-primary-onBackground to @text directly instead of using targeted selectors to override text color on gradient backgrounds.
c475d39 to
e8bf547
Compare
|
Switched to setting --color-primary-onBackground to @text directly and removed the targeted selectors. Also rebased onto latest main. |




🔧 What does this fix? 🔧
Fixes black/unreadable text on the Trending Today carousel cards on the Reddit homepage.
The
text-primary-onBackgroundclass uses--color-primary-onBackground, which the theme sets to a dark color. This breaks text that appears over image cards with gradient overlays.Fix targets elements inside gradient backgrounds and forces white text: