Skip to content

fix(reddit): trending carousel cards text#2114

Merged
uncenter merged 4 commits intocatppuccin:mainfrom
rohanp2051:fix/reddit-trending-carousel-text
Mar 8, 2026
Merged

fix(reddit): trending carousel cards text#2114
uncenter merged 4 commits intocatppuccin:mainfrom
rohanp2051:fix/reddit-trending-carousel-text

Conversation

@rohanp2051
Copy link
Copy Markdown
Contributor

🔧 What does this fix? 🔧

Fixes black/unreadable text on the Trending Today carousel cards on the Reddit homepage.

The text-primary-onBackground class uses --color-primary-onBackground, which the theme sets to a dark color. This breaks text that appears over image cards with gradient overlays.

Fix targets elements inside gradient backgrounds and forces white text:

@github-actions github-actions bot added the reddit Reddit label Feb 1, 2026
@uncenter
Copy link
Copy Markdown
Member

uncenter commented Feb 1, 2026

Can I see a screenshot of these elements before and after? And can you clarify where these elements are meant to be? I've been poking around the site while both logged in and not and haven't seen this issue.

@rohanp2051
Copy link
Copy Markdown
Contributor Author

Here is what it was looking like before:
Screenshot 2026-01-31 at 8 11 44 PM
Here is after:
Screenshot 2026-01-31 at 8 09 28 PM

@WalkQuackBack WalkQuackBack added 0.kind: bug Bug (i.e. unthemed components) 5.needs: staff-review A review by a staff member is required/needed labels Feb 1, 2026
@uncenter uncenter added the 5.needs: reproduction Unable to reproduce, more details needed label Feb 1, 2026
@uncenter
Copy link
Copy Markdown
Member

uncenter commented Feb 1, 2026

I still can't locate those cards on my Reddit page, is this something I need to configure/enable/toggle in settings?

@rohanp2051
Copy link
Copy Markdown
Contributor Author

I think the issue is that your signed in. This is what reddit.com looks like for users that aren't signed in or using any extensions for modification.

@uncenter
Copy link
Copy Markdown
Member

uncenter commented Feb 2, 2026

Ah thanks I opened in a new clean window and reproduced.

@uncenter uncenter removed the 5.needs: reproduction Unable to reproduce, more details needed label Feb 2, 2026
@uncenter
Copy link
Copy Markdown
Member

uncenter commented Feb 2, 2026

Can we try setting --color-primary-onBackground to @text directly? Nothing looks immediately broken with that change.

@uncenter uncenter added 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review and removed 5.needs: staff-review A review by a staff member is required/needed labels Feb 19, 2026
Set --color-primary-onBackground to @text directly instead of using
targeted selectors to override text color on gradient backgrounds.
@rohanp2051 rohanp2051 force-pushed the fix/reddit-trending-carousel-text branch from c475d39 to e8bf547 Compare February 26, 2026 15:03
@rohanp2051
Copy link
Copy Markdown
Contributor Author

rohanp2051 commented Feb 26, 2026

Switched to setting --color-primary-onBackground to @text directly and removed the targeted selectors. Also rebased onto latest main.
image

@uncenter
Copy link
Copy Markdown
Member

uncenter commented Mar 1, 2026

Shoot I'm sorry actually I think I mislead you. As soon as you changed that I noticed this case where this text ("NEW") would previously have been base but now is text and lacks contrast.

CleanShot 2026-02-26 at 09 16 46@2x

Sorry for the hassle, can we go back to your original solution?

@uncenter uncenter removed the 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review label Mar 8, 2026
@uncenter uncenter changed the title fix(reddit): restore white text on trending carousel cards fix(reddit): trending carousel cards text Mar 8, 2026
@uncenter uncenter merged commit 8ce4e7e into catppuccin:main Mar 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: bug Bug (i.e. unthemed components) reddit Reddit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants