Remove empty-argument optimisation

This doesn't work with getTableUnsafe, as empty arguments are considered
closed already. We could argubly special-case the empty args, but the
optimisation has very minor benefits, so I don't think worrying about too
much.

Fixes #2246.

Author: SquidDev

projects/core/src/main/java/dan200/computercraft/core/lua/VarargArguments.java

@@ -20,13 +20,8 @@
 final class VarargArguments implements IArguments {
     private static final Logger LOG = LoggerFactory.getLogger(VarargArguments.class);
 
-    private static final VarargArguments EMPTY = new VarargArguments(Constants.NONE);
     private static boolean reportedIllegalGet;
 
-    static {
-        EMPTY.escapes = EMPTY.closed = true;
-    }
-
     private final Varargs varargs;
 
     private volatile boolean closed;
@@ -51,7 +46,7 @@ private VarargArguments(Varargs varargs, VarargArguments root, int offset) {
     }
 
     static VarargArguments of(Varargs values) {
-        return values == Constants.NONE ? EMPTY : new VarargArguments(values);
+        return new VarargArguments(values);
     }
 
     boolean isClosed() {
@@ -138,9 +133,7 @@ public IArguments drop(int count) {
         if (count < 0) throw new IllegalStateException("count cannot be negative");
         if (count == 0) return this;
 
-        var newArgs = varargs.subargs(count + 1);
-        if (newArgs == Constants.NONE) return EMPTY;
-        return new VarargArguments(newArgs, this, count);
+        return new VarargArguments(varargs.subargs(count + 1), this, count);
     }
 
     @Override