Add maildat columns to default.vw_pin_address#980
Open
wrridgeway wants to merge 11 commits intomasterfrom
Open
Add maildat columns to default.vw_pin_address#980wrridgeway wants to merge 11 commits intomasterfrom
default.vw_pin_address#980wrridgeway wants to merge 11 commits intomasterfrom
Conversation
Member
Author
|
@ccao-jardine Are you okay with the taxpayer/owner dichotomy I've gone with here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
iasworld.maildattodefault.vw_pin_addressas the new source ofmail_columns. We keep columns fromiasworld.owndat, but we rename these columns with anowner_prefix. This allows us to avoid committing entirely to one table or the other and provide as much information to users as possible while being clear about the limitations of both sources of address data.The only real nuance here is that
maildatis not unique by pin and year whencur = 'Y' and deactivat is nulllike most iasworld tables. Instead we also need to depend onmailseqand choosing which value ofmailseqto privilege in order to makemaildatunique by pin and year (we take the max value) boiled down to trying to match up with what's displayed on the treasurer's website. Two example pins are below:Updates have not changed row count, as expected:
returns nothing. and
mail_address_fullis largely non-null: