feat: Improve compatiblity with typescript >= 4.3 #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
March 6, 2025 06:58
Head branch was pushed to by a user without write access
hamnis
changed the title
|
@hamnis you need to run |
Introduces override keyword to make sure we can typecheck the file, with noImplicitOverride turned on. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-3.html#override-and-the---noimplicitoverride-flag Signed-off-by: Erlend Hamnaberg <erlend@hamnaberg.net>
Signed-off-by: Erlend Hamnaberg <erlend@hamnaberg.net>
|
@iliapolo I think the build should be able to be run now? |
iliapolo
approved these changes
May 29, 2025
|
@renannprado i have no idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces override keyword to make sure we can typecheck the file, with noImplicitOverride turned on.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-3.html#override-and-the---noimplicitoverride-flag