Merge pull request #24 from slimshreydy/main

stephanlensky · web-flow · commit a0104c8074f9 · 2024-11-23T21:35:53.000-05:00
Fixes #23, error with headless mode where user agent tuple is incorrectly processed
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fix `AttributeError: 'tuple' object has no attribute 'value'` error in `connection.py` when using headless browser, @slimshreydy
+
 ### Added
 
 ### Changed
diff --git a/zendriver/core/connection.py b/zendriver/core/connection.py
@@ -505,8 +505,8 @@ async def _prepare_headless(self):
                 allow_unsafe_eval_blocked_by_csp=True,
             )
         )
-        if response and response.value:
-            ua = response.value
+        if response and response[0].value:
+            ua = response[0].value
             await self._send_oneshot(
                 cdp.network.set_user_agent_override(
                     user_agent=ua.replace("Headless", ""),

Original file line number	Diff line number	Diff line change
`@@ -505,8 +505,8 @@ async def _prepare_headless(self):`
`505`	`505`	`allow_unsafe_eval_blocked_by_csp=True,`
`506`	`506`	`)`
`507`	`507`	`)`
`508`		`- if response and response.value:`
`509`		`- ua = response.value`
	`508`	`+ if response and response[0].value:`
	`509`	`+ ua = response[0].value`
`510`	`510`	`await self._send_oneshot(`
`511`	`511`	`cdp.network.set_user_agent_override(`
`512`	`512`	`user_agent=ua.replace("Headless", ""),`