Make Browser.get and Tab.close wait for their appropiate target events before returning (#91)

* Wait for their appropiate target events before returning Browser.get and Tab.close

* fix mypy issues

* always wait for TargetInfoChanged in Browser.get

---------

Co-authored-by: Stephan Lensky <8302875+stephanlensky@users.noreply.github.com>

Author: ccev

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- `Browser.get` and `Tab.close` will now wait for their appropiate target events before returning @ccev
+
 ### Added
 
 - Added `Tab.save_snapshot` to export the current page to MHTML format.

zendriver/core/browser.py

@@ -252,10 +252,19 @@ async def get(
         :param new_tab: open new tab
         :param new_window:  open new window
         :return: Page
+        :raises: asyncio.TimeoutError
         """
         if not self.connection:
             raise RuntimeError("Browser not yet started. use await browser.start()")
 
+        future = asyncio.get_running_loop().create_future()
+        event_type = cdp.target.TargetInfoChanged
+
+        async def get_handler(event: cdp.target.TargetInfoChanged) -> None:
+            future.set_result(event)
+
+        self.connection.add_handler(event_type, get_handler)
+
         if new_tab or new_window:
             # create new target using the browser session
             target_id = await self.connection.send(
@@ -271,15 +280,16 @@ async def get(
                 )
             )
             connection.browser = self
-
         else:
             # first tab from browser.tabs
             connection = next(filter(lambda item: item.type_ == "page", self.targets))
             # use the tab to navigate to new url
             await connection.send(cdp.page.navigate(url))
             connection.browser = self
 
-        await connection.sleep(0.25)
+        await asyncio.wait_for(future, 10)
+        self.connection.remove_handlers(event_type, get_handler)
+
         return connection
 
     async def start(self) -> Browser:

zendriver/core/tab.py

@@ -907,10 +907,28 @@ async def close(self):
         close the current target (ie: tab,window,page)
         :return:
         :rtype:
+        :raises: asyncio.TimeoutError
+        :raises: RuntimeError
         """
+
+        if not self.browser or not self.browser.connection:
+            raise RuntimeError("Browser not yet started. use await browser.start()")
+
+        future = asyncio.get_running_loop().create_future()
+        event_type = cdp.target.TargetDestroyed
+
+        async def close_handler(event: cdp.target.TargetDestroyed) -> None:
+            if self.target and event.target_id == self.target.target_id:
+                future.set_result(event)
+
+        self.browser.connection.add_handler(event_type, close_handler)
+
         if self.target and self.target.target_id:
             await self.send(cdp.target.close_target(target_id=self.target.target_id))
 
+        await asyncio.wait_for(future, 10)
+        self.browser.connection.remove_handlers(event_type, close_handler)
+
     async def get_window(self) -> Tuple[cdp.browser.WindowID, cdp.browser.Bounds]:
         """
         get the window Bounds