Fixing tests to make them run and pass on Windows (#116)

* fix: allows tests to be run on windows (SIGUSR1 not supported)

* fix: escape url pattern for regex, since windows uses backslash which makes it crash

* fix: using forward slashes in file path since cdp always returns back forward slashes

* run format + update changelogs

* feat: run ci on windows

* portable way to get chrome version (windows fix)

Author: nathanfallet

.github/workflows/test.yml

@@ -13,7 +13,10 @@ on:
   workflow_dispatch:
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, windows-latest ]
     steps:
       - uses: actions/checkout@v4
       - name: Install uv
@@ -26,4 +29,5 @@ jobs:
         env:
           ZENDRIVER_TEST_BROWSERS: "headless"
           ZENDRIVER_TEST_NO_SANDBOX: "true"
-        run: /bin/bash ./scripts/test.sh
+        shell: bash
+        run: ./scripts/test.sh

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fixing tests so that they can run on Windows (and still run on Linux like before) @nathanfallet
+
 ### Added
 
 ### Changed

scripts/test.sh

@@ -10,9 +10,7 @@ fi
 chrome_executable=$(uv run python -c "from zendriver.core.config import find_chrome_executable;print(find_chrome_executable())")
 echo "Chrome executable: $chrome_executable"
 
-chrome_cmd=( "$chrome_executable" )
-chrome_cmd+=("--version")
-chrome_version=$("${chrome_cmd[@]}")
+chrome_version=$(uv run python -c "import os, subprocess, sys; path = r'$chrome_executable'; print(subprocess.run([path, '--version'], capture_output=True, text=True).stdout.strip()) if os.name != 'nt' else print('SKIP: Windows chrome.exe may not return version')")
 echo "Chrome version: $chrome_version"
 
 set -x

tests/conftest.py

@@ -123,4 +123,9 @@ def handle_next_test(signum, frame):
     NEXT_TEST_EVENT.set()
 
 
-signal.signal(signal.SIGUSR1, handle_next_test)
+if hasattr(signal, "SIGUSR1"):
+    signal.signal(signal.SIGUSR1, handle_next_test)
+else:
+    logger.warning(
+        "SIGUSR1 not available on this platform, handle_next_test will not be called."
+    )

tests/sample_data/__init__.py

@@ -2,5 +2,5 @@
 
 
 def sample_file(name: str) -> str:
-    path = (Path(__file__).parent / name).absolute()
-    return f"file://{path}"
+    path = (Path(__file__).parent / name).resolve()
+    return path.as_uri()