Update CHANGELOG.md and type browser config arg

Author: stephanlensky

CHANGELOG.md

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- Add support for Brave browser @H1steria
+
 ### Changed
 
 ### Removed

zendriver/core/browser.py

@@ -22,7 +22,7 @@
 from .. import cdp
 from . import tab, util
 from ._contradict import ContraDict
-from .config import Config, PathLike, is_posix
+from .config import BrowserType, Config, PathLike, is_posix
 from .connection import Connection
 
 logger = logging.getLogger(__name__)
@@ -73,7 +73,7 @@ async def create(
         headless: bool = False,
         user_agent: str | None = None,
         browser_executable_path: PathLike | None = None,
-        browser: str = "auto",
+        browser: BrowserType = "auto",
         browser_args: List[str] | None = None,
         sandbox: bool = True,
         lang: str | None = None,

zendriver/core/config.py

@@ -6,7 +6,7 @@
 import sys
 import tempfile
 import zipfile
-from typing import Any, List, Optional, Union
+from typing import Any, List, Literal, Optional, Union
 
 __all__ = [
     "Config",
@@ -23,6 +23,8 @@
 PathLike = Union[str, pathlib.Path]
 AUTO = None
 
+BrowserType = Literal["chrome", "brave", "auto"]
+
 
 class Config:
     """
@@ -34,7 +36,7 @@ def __init__(
         user_data_dir: Optional[PathLike] = AUTO,
         headless: Optional[bool] = False,
         browser_executable_path: Optional[PathLike] = AUTO,
-        browser: str = "auto",
+        browser: BrowserType = "auto",
         browser_args: Optional[List[str]] = AUTO,
         sandbox: Optional[bool] = True,
         lang: Optional[str] = None,
@@ -75,7 +77,7 @@ def __init__(
         :type user_data_dir: PathLike
         :type headless: bool
         :type browser_executable_path: PathLike
-        :type browser: str
+        :type browser: BrowserType
         :type browser_args: list[str]
         :type sandbox: bool
         :type lang: str
@@ -306,7 +308,7 @@ def find_binary(candidates):
     return winner
 
 
-def find_executable(browser: str = "auto") -> PathLike:
+def find_executable(browser: BrowserType = "auto") -> PathLike:
     """
     Finds the executable for the specified browser and returns its disk path.
     :param browser: The browser to find. Can be "chrome", "brave" or "auto".

zendriver/core/util.py

@@ -17,7 +17,7 @@
 if typing.TYPE_CHECKING:
     from .browser import Browser, PathLike
 from .. import cdp
-from .config import Config
+from .config import BrowserType, Config
 
 __registered__instances__: Set[Browser] = set()
 
@@ -31,7 +31,7 @@ async def start(
     user_data_dir: Optional[PathLike] = None,
     headless: Optional[bool] = False,
     browser_executable_path: Optional[PathLike] = None,
-    browser: str = "auto",
+    browser: BrowserType = "auto",
     browser_args: Optional[List[str]] = None,
     sandbox: Optional[bool] = True,
     lang: Optional[str] = None,