feature: add celery_beat_task header in task options #9702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #9702 +/- ##
=======================================
Coverage 78.30% 78.31%
=======================================
Files 153 153
Lines 19127 19129 +2
Branches 2533 2533
=======================================
+ Hits 14978 14980 +2
Misses 3860 3860
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new custom header, celery_beat_task, into task options so that tasks dispatched by Celery Beat can be reliably identified.
- Added tests in t/unit/app/test_beat.py to verify the header is correctly injected and that existing headers are preserved.
- Updated celery/beat.py to merge the new header into task options during task dispatch.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| t/unit/app/test_beat.py | Added unit tests for header injection and preservation. |
| celery/beat.py | Enhanced apply_async to include the celery_beat_task header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new custom header
celery_beat_taskto task options, enabling reliable identification of tasks originating from Celery Beat. This enhancement addresses the challenge discussed in one of django-celery-beat issues (number 854).Changes
celery_beat_taskheader to task options when tasks are sent by Celery BeatRelated Issues
celery/django-celery-beat#854