Skip to content

fix(txsim): pollTime CLI flag should override environment variable #5268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+48 −5
Open

fix(txsim): pollTime CLI flag should override environment variable #5268

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2847f7d
fix: pollTime flag and environment variable priority logic
Galoretka Jul 16, 2025
c4864cb
Update cli.go
Galoretka Jul 18, 2025
48a7919
Update cli_test.go
Galoretka Jul 18, 2025
8538597
Update test/cmd/txsim/cli.go
rootulp Jul 18, 2025
53c5c6a
Update test/cmd/txsim/cli.go
rootulp Jul 18, 2025
b6b3315
Update test/cmd/txsim/cli.go
rootulp Jul 18, 2025
3b05ac0
Update test/cmd/txsim/cli.go
rootulp Jul 18, 2025
ce54b0c
Update test/cmd/txsim/cli_test.go
rootulp Jul 18, 2025
521715e
Merge branch 'main' into fix/polltime-env-flag-priority
rootulp Jul 18, 2025
523561a
Update cli.go
Galoretka Jul 26, 2025
e3ad00c
Update cli_test.go
Galoretka Jul 26, 2025
04aa19f
Merge branch 'main' into fix/polltime-env-flag-priority
evan-forbes Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/cmd/txsim/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ account that can act as the master account. The command runs until all sequences
}
}

if os.Getenv(TxsimPoll) != "" && pollTime != user.DefaultPollTime {
// set pollTime: flag has priority, then env var, then default
if pollTime == user.DefaultPollTime && os.Getenv(TxsimPoll) != "" {
pollTime, err = time.ParseDuration(os.Getenv(TxsimPoll))
if err != nil {
return fmt.Errorf("parsing poll time: %w", err)
Expand Down